Skip to content

Correctly return the source file for ScalarValue objects #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Mar 19, 2025


Description

Since ScalarValue objects now have base attributes (as they can have
descriptions, preferredName and see references), they should also correctly
return their source file when getSourceFile() is called.

Fixes #726

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 1d810d7 into eclipse-esmf:main Mar 20, 2025
4 checks passed
@atextor atextor deleted the 726-scalar-value-source-file-is-null branch March 20, 2025 06:45
Copy link

Release v2.10.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] getSourceFile() for ScalarValue objects returns null
3 participants